Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MikroORM v6 compatibility #6

Merged
merged 2 commits into from
Jan 11, 2024
Merged

MikroORM v6 compatibility #6

merged 2 commits into from
Jan 11, 2024

Conversation

Tucker-Eric
Copy link

@Tucker-Eric Tucker-Eric commented Jan 10, 2024

Allows compatibility with MikroORM v6 (closes #5 )

Notable changes made for V6:

Due to all these updates required by v6 there is a very high likelihood backwards compatibility won't be preserved for some implementations of mikro-orm-soft-delete

@Char2sGu
Copy link
Owner

Awesome updates! @Tucker-Eric I'll merge it soon after making some small changes to it.

Copy link
Owner

@Char2sGu Char2sGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Tucker-Eric

@Char2sGu Char2sGu merged commit 05dd145 into Char2sGu:main Jan 11, 2024
@Tucker-Eric Tucker-Eric deleted the mikro-orm-v6 branch January 11, 2024 16:11
@Tucker-Eric
Copy link
Author

@TheNightmareX The one thing I wish I could of done but couldn't see a path to implement was get the @SoftDeletable decorator to throw an error if the subscriber wasn't registered. If you're able to see a path forward/point me in the right direction, I could open a follow up PR.

@Char2sGu
Copy link
Owner

Hey @Tucker-Eric let's continue this discussion in #7 as this is out of the scope of this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Mikro ORM V6
2 participants