Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only wrap webhook requests in verifySignature #84

Closed
mraaroncruz opened this issue Nov 25, 2017 · 2 comments
Closed

Only wrap webhook requests in verifySignature #84

mraaroncruz opened this issue Nov 25, 2017 · 2 comments
Assignees
@mraaroncruz
Labels
enhancement

Comments

@mraaroncruz
Copy link
Collaborator

Make it easier to add other express endpoints by limiting signature requests to the webhook get and post requests instead of being a global middleware.
Related to #48
@mraaroncruz mraaroncruz self-assigned this Nov 25, 2017
@mraaroncruz mraaroncruz mentioned this issue Nov 25, 2017
Closed
@mchingiz mchingiz mentioned this issue Feb 13, 2018
Open
@mahmed0715
Copy link

+1

@mahmed0715
Copy link

I am currently having this issue. needed to do

this.app.use('/webhook', bodyparser.json({verify:FBVERIFY()}))

explicitly.
Please fix this..

@Charca Charca closed this as completed in 997facb Nov 9, 2018
Charca added a commit that referenced this issue Nov 9, 2018
@Charca
Merge pull request #158 from chr0m1ng/master
8884e72 
Fix #84. Add this.webhook at bodyParser.use.
@balazsorban44 balazsorban44 mentioned this issue Apr 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mraaroncruz mraaroncruz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mraaroncruz @mahmed0715