Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid .pullapprove.yml #1345

Closed
tripleee opened this issue Dec 7, 2017 · 4 comments
Closed

Invalid .pullapprove.yml #1345

tripleee opened this issue Dec 7, 2017 · 4 comments

Comments

@tripleee
Copy link
Member

tripleee commented Dec 7, 2017

Chasing the error message on pullapprove.com is incredibly complex IMHO.

I see 'hichris1234' is not a collaborator of this repo in the error message at https://pullapprove.com/Charcoal-SE/SmokeDetector/

I imagine the correct fix is to mark hichris1234 as a collaborator in GitHub.

tripleee added a commit that referenced this issue Dec 7, 2017
@tripleee
Copy link
Member Author

tripleee commented Dec 7, 2017

I temporarily removed hichris1234 from .pullapprove.yml but I'll leave this open for visibility and discussion. Ideally I'd like to be able to uncomment the fix.

tripleee added a commit to tripleee/SmokeDetector that referenced this issue Dec 7, 2017
rjrudman pushed a commit to rjrudman/SmokeDetector that referenced this issue Dec 7, 2017
@NobodyNada
Copy link
Member

@tripleee This happened when I was added to that list as well. IIRC, the fix was to add me to the OAP team of the Charcoal org.

@tripleee
Copy link
Member Author

tripleee commented Dec 7, 2017

Yeah, but Chris was there like forever, was he recently removed from the org on GitHub, or what?

tripleee added a commit to tripleee/SmokeDetector that referenced this issue Dec 7, 2017
@tripleee
Copy link
Member Author

tripleee commented Dec 7, 2017

hichris1234 is now @csnardi apparently. Thanks to @ArtOfCode- for the explanation.

https://chat.stackexchange.com/transcript/message/41596394#41596394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants