Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated phone numbers in "bad_keyword.txt" #1442

Closed
iBug opened this issue Jan 3, 2018 · 1 comment
Closed

Duplicated phone numbers in "bad_keyword.txt" #1442

iBug opened this issue Jan 3, 2018 · 1 comment
Labels
status: completed That probably took longer than we said it would.

Comments

@iBug
Copy link
Member

iBug commented Jan 3, 2018

On Line 233, there's a pattern (?<=\+)234\d{8,14} that covers any phone number that starts with +234. Meanwhile, there are 9 other lines about individual phone numbers starting with 234 (no plus sign). I suggest removing the duplicated lines and remove the positive lookbehind for the plus sign on Line 233.

The dupe lines are 425, 461, 533, 549, 564, 571, 661, 937, 1007.

Line 233 modification proposal:

\+?234\W*\d{3}\W*\d{3}\W*\d{4,10}
iBug added a commit to iBug/SmokeDetector that referenced this issue Jan 4, 2018
Remove duplicated phone number pattern according to [Issue Charcoal-SE#1442](Charcoal-SE#1442). Minor merges.
@iBug iBug mentioned this issue Jan 4, 2018
@iBug iBug closed this as completed Jan 7, 2018
@iBug
Copy link
Member Author

iBug commented Jan 7, 2018

As PR #1446 is merged already, this issue should be considered [status-completed].

@angussidney angussidney added the status: completed That probably took longer than we said it would. label Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: completed That probably took longer than we said it would.
Development

No branches or pull requests

2 participants