Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smarter tp/fp comments from metasmoke on blacklist request #441

Closed
1 of 2 tasks
rjrudman opened this issue Jan 4, 2017 · 8 comments · Fixed by Charcoal-SE/metasmoke#295
Closed
1 of 2 tasks

Smarter tp/fp comments from metasmoke on blacklist request #441

rjrudman opened this issue Jan 4, 2017 · 8 comments · Fixed by Charcoal-SE/metasmoke#295
Assignees
@angussidney
Labels
type: feature request Shinies.

Comments

@rjrudman
Copy link
Contributor

rjrudman commented Jan 4, 2017 •
edited by angussidney

See here for an example.

A user requested that a username should be blacklisted - which prompted the usual metasmoke comment. However - the result only checks for true/false positives in post bodies, rather than the username.

  • Fix comment
  • Fix link in PR
@angussidney angussidney self-assigned this Jan 4, 2017
@Undo1
Copy link
Member

Undo1 commented Jan 4, 2017

@angussidney Are you doing both sides of this?

@angussidney
Copy link
Member

@Undo1 Completely forgot about the comment :) I can do the search link (since that can be done smokey side), but not the comment.

@Undo1 Undo1 self-assigned this Jan 5, 2017
angussidney added a commit that referenced this issue Jan 6, 2017
@angussidney
Fix MS searches for usernames (see #441)
dc3daf2
@angussidney angussidney mentioned this issue Jan 18, 2017
Merged
@Undo1 Undo1 removed their assignment Jan 18, 2017
@angussidney angussidney added the status: completed That probably took longer than we said it would. label Jan 23, 2017
angussidney added a commit that referenced this issue Jan 23, 2017
@angussidney
Add proper MS notification to auto-blacklists --autopull
5aac465 
Finishes #441
@angussidney angussidney removed the status: completed That probably took longer than we said it would. label Jan 23, 2017
@angussidney angussidney reopened this Jan 23, 2017
@angussidney
Copy link
Member

angussidney commented Jan 23, 2017 •
edited

MS doesn't seem to be leaving a comment

#478

@quartata
Copy link
Member

I'm not sure why this isn't working -- SmokeDetector is including the proper metadata, so the only thing I can think of is that the MS webhook has been disconnected (@ArtOfCode-)?

@ArtOfCode-
Copy link
Member

@Undo1 will need to verify that, since he has the GH secret.

@Undo1
Copy link
Member

Undo1 commented Nov 26, 2017 •
edited

@quartata @ArtOfCode- Dug through the GH hook logs. There's at least two issues here. Attached a couple of backtraces; filenames contain SD PR numbers they happened on.

metasmoke-backtraces.zip

@ArtOfCode-
Copy link
Member

TL;DR: someone, somewhere, has misunderstood what String#scan returns.

@angussidney
Copy link
Member

Probably my fault, sorry

@quartata quartata mentioned this issue Dec 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angussidney angussidney

Labels
type: feature request Shinies.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix MS tp/fp comments
5 participants
@rjrudman @angussidney @Undo1 @ArtOfCode- @quartata