Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion watcher missing some messages? #928

Closed
tripleee opened this issue Jun 7, 2022 · 2 comments
Closed

Deletion watcher missing some messages? #928

tripleee opened this issue Jun 7, 2022 · 2 comments

Comments

@tripleee
Copy link
Member

tripleee commented Jun 7, 2022

What problem has occurred? What issues has it caused?

Shadow complained about a message which got reported in the Tavern even though it was already deleted.

Speculations abound, but the message still isn't reported as deleted in metasmoke.

https://chat.meta.stackexchange.com/transcript/message/9228055#9228055

What would you like to happen/not happen?

The deletion watcher should have noticed that the message was deleted, and ideally have removed the message from the Tavern if it was posted before the message was deleted, or else not have posted it at all.

@ThatRyanPerson
Copy link

If it's the issue I've been seeing, if the post is deleted before the MS report is complete, then the deletion watcher won't catch it. That doesn't generally happen unless a mod nukes it very quickly...which appears to have happened here, as it's at -1 and deleted 19 seconds after it was posted.
As a Stack Overflow mod who frequently reports to Charcoal, it's not at all uncommon for me to nuke the post a little too quickly before the deletion watcher is ready, so I've seen this a bunch of times. Of course, the room where it's supposed to auto-delete is on SO chat, so I tend to solve it by deleting the messages myself...
Basically, it requires deleting the post after SD has read the contents, but before it's reported to MS.

@tripleee tripleee transferred this issue from Charcoal-SE/SmokeDetector Jun 8, 2022
@makyen
Copy link
Contributor

makyen commented Jul 21, 2022

This appears to be entirely about deleting or not posting SD reports in chat when a post has been deleted, rather than something on MS. So, this is actually an SD issue. However, as far as I'm aware this has been resolved. So, rather than move it to the SD repo, I'm just going to close it.

@makyen makyen closed this as completed Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants