Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!/unnotify shorthand #1179

Merged
merged 1 commit into from
Oct 29, 2017
Merged

!!/unnotify shorthand #1179

merged 1 commit into from
Oct 29, 2017

Conversation

Papershine
Copy link
Member

@Papershine Papershine commented Oct 29, 2017

This fixes #1164 (the shorthand for !!/unnotify)

@codecov-io
Copy link

codecov-io commented Oct 29, 2017

Codecov Report

Merging #1179 into master will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
+ Coverage   64.21%   64.22%   +<.01%     
==========================================
  Files           6        6              
  Lines        1811     1814       +3     
==========================================
+ Hits         1163     1165       +2     
- Misses        648      649       +1
Impacted Files Coverage Δ
datahandling.py 55.23% <75%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2da1a5...65121aa. Read the comment docs.

@Papershine Papershine closed this Oct 29, 2017
@Papershine Papershine reopened this Oct 29, 2017
@j-f1
Copy link
Contributor

j-f1 commented Oct 29, 2017

Looks great @paper1111. Tip: if you edit the initial PR comment to say fixes #1164, the issue will automatically be closed when the PR gets merged.

@Papershine
Copy link
Member Author

@j-f1 is it like this?

@j-f1
Copy link
Contributor

j-f1 commented Oct 29, 2017

Yes!

@ArtOfCode- ArtOfCode- merged commit 6ecd32e into Charcoal-SE:master Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

!!/notify works with the short URL version, but !!/unnotify doesn't
5 participants