Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FP fix for tcl.tk #1230

Merged
merged 1 commit into from Nov 16, 2017
Merged

FP fix for tcl.tk #1230

merged 1 commit into from Nov 16, 2017

Conversation

tripleee
Copy link
Member

Exclude the main TCL site from the *.tk answer regexes.

I can find no good way to test this so just throwing a PR in the hopes that someone can validate the fix.

@tripleee
FP fix for tcl.tk
a40ec5b 
Exclude the main TCL site from the *.tk answer regexes
@Glorfindel83
Copy link
Member

Looks to good to me, except that regex101.com claims you need to escape the slash (in [/.], so [\/.]). Does that work differently in Python?

@j-f1
Copy link
Contributor

j-f1 commented Nov 16, 2017

Yes — that only is necessary if the language uses / to delimit regular expressions.

@angussidney
Copy link
Member

angussidney commented Nov 16, 2017 •
edited by ArtOfCode-

!!/approve

Approved with PullApprove

@angussidney angussidney merged commit d441db2 into Charcoal-SE:master Nov 16, 2017
@tripleee tripleee deleted the tcl-tk-fp-fix branch April 6, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tripleee @Glorfindel83 @j-f1 @angussidney