findspam.py: watch_ns_for_url_domain #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tripleee
force-pushed
the
watch-ns
branch
2 times, most recently
from
4a669f0
to
9a4dd64
Compare
j-f1
reviewed
Apr 25, 2018
findspam.py
Outdated
| def watched_ns_for_url_domain(s, site, *args): | ||
| return ns_for_url_domain(s, site, [ | ||
| # Don't forget the trailing dot on the resolved name here either! | ||
| {'pablo.ns.cloudflare.com', 'pola.ns.cloudflare.com.'}, |
Refactor bad_ns_for_url_domain to an analysis function ns_for_url_domain and two caller functions which call it with different lists of nameservers
|
Rebased to squish typo fixes etc into one commit; sorry for the noise. |
|
Subtle poke? ;) I'll have a look later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor bad_ns_for_url_domain to an anlysis function ns_for_url_domain
and two caller functions which call it with different lists of nameservers