Quick and dirty solution for blacklist patterns that would have spaces #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith spaces This would prevent multiple patterns from getting added by patterns which would have unescaped spaces in them. This quick and dirty hack was suggested by Undo.
Necessary to sync up with all the other changes so we aren't out of sync with Master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we split on spaces. For the blacklist commands, we are going to join multiple message parts with spaces, under the assumption that only one pattern is actually provided at a time. Also, we need to include a merge from Master into this branch, because I made a mistake of not updating the Master branch first. (My bad!)