Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name to Xnero #5903

Closed
wants to merge 2 commits into from
Closed

Change name to Xnero #5903

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 18, 2021

No description provided.

@tripleee
Copy link
Member

The Git history will of course still contain the original user name.

@ghost
Copy link
Author

ghost commented Feb 18, 2021

The Git history will of course still contain the original user name.

@tripleee I know, its just for statistics and consistency.

@makyen
Copy link
Contributor

makyen commented Feb 18, 2021

I'm going to close this PR, because the change to watched_keywords.txt changes every line in the file, rather than just the lines with "Daniil". This is probably a change to the line endings, but I didn't actually check. I'm not set against the change that appears to be desired here, but we definitely don't want that specific commit added to the repository.

The most likely way for the line endings to have changed is for the file to be edited on a Windows system and then pushed to GitHub. There are a variety of things which might have gone wrong when doing that which could result in a change to the line endings (i.e. there are too many possible issues which might have caused that to be able to say exactly what the cause was without more information/investigation).

@makyen makyen closed this Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants