Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure post queue timings #598

Merged
merged 5 commits into from
Mar 18, 2017
Merged

Measure post queue timings #598

merged 5 commits into from
Mar 18, 2017

Conversation

ArtOfCode-
Copy link
Member

@ArtOfCode- ArtOfCode- commented Mar 17, 2017

This should measure how long a post has been in the bodyfetcher queue at the point that the API call for its site is made. It stores the timings locally in bodyfetcherQueueTimings.p so that stats can be analysed. Also created a Python script to do that analysis.

PR'd so I can get a code review, and cc @Undo1 since he was talking about doing this.

@ArtOfCode- ArtOfCode- added the type: feedback wanted "Closed as too opinion-based." label Mar 17, 2017
@ArtOfCode- ArtOfCode- merged commit ec0b1fa into master Mar 18, 2017
Undo1 added a commit that referenced this pull request Mar 18, 2017
Revert "Queue: List/Tuple replace with a Dict for proper functions."

This reverts commit 5c23a3f.

Revert "Python2/3 Reverse Compat functionality, also 'return' if EOFError"

This reverts commit f604590.

Revert "Ain't flake great"

This reverts commit 13f9301.

Revert "Shorten site names"

This reverts commit a46f747.

Revert "Merge pull request #598 from Charcoal-SE/time-in-queue"

This reverts commit ec0b1fa, reversing
changes made to 92adc01.

Revert "Merge pull request #599 from quartata/master"

This reverts commit 92adc01, reversing
changes made to 95ee2fe.
@teward
Copy link
Member

teward commented Mar 18, 2017

Just a note that this broke some things, too, so we had to revert it in commit 0177abf, but it's now fixed (via 5c23a3f and subsequent error handling checks in 706420d). (Core issue: dict and lists aren't interchangeable, and we have to do some manipulation to make things work proper as dicts or lists, while also erasing and starting with a fresh pickle (done via 10425ad to forcibly delete queue pickles once at load, which we did by manually failing over to each instance; make sure that 47d0cf9 is also pulled in to keep it from constantly deleting though, @ArtOfCode-, as your instance is the only one that didn't get 47d0cf9's removal of the "Destroy the Pickles" code)

@ArtOfCode-
Copy link
Member Author

@teward I nuked the bodyfetcher queue manually, because yeah it broke things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feedback wanted "Closed as too opinion-based."
Development

Successfully merging this pull request may close these issues.

None yet

2 participants