Added 'mostly dots' rule #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtOfCode-
reviewed
Mar 19, 2017
|
|
||
| dot_count = len(regex.findall("\.", body)) | ||
|
|
||
| if body_length and dot_count / float(body_length) >= 0.4: |
There was a problem hiding this comment.
Because Python 2 does integer division when both are ints. (and we're not using __future__)
There was a problem hiding this comment.
/me is too used to Python 3.
There was a problem hiding this comment.
We can always import __future__ but we'd have to redo a large portion of our math. I only recently starting using the division aspect of __future__ in one of my other scripts, but so far I'm a fan of it. I'm not a fan of some other aspects of Python 3 though. Yet.
There was a problem hiding this comment.
from __future__ import braces
There was a problem hiding this comment.
from __future__ import division would work too, but... eh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been getting a rash of spam posts that try to be "clever" like this: http://chat.stackexchange.com/transcript/message/36131864#36131864
We catch them anyways since our phone number detection isn't dumb, but I figured it wouldn't hurt to throw in an extra rule to catch them. This rule will trip if the ratio of dots to characters in the post is greater than 40%.