globalvars.py: Use ConfigParser instead of RawConfigParser #6540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the documentation for `configparser.RawConfigParser` (https://docs.python.org/3/library/configparser.html#configparser.RawConfigParser), this is a **legacy** API call that allows for non-string section names, option names, and values via the unsafe `add_section` and `set` methods. We don't use those methods, but it's overall still a legacy compatibility and should be avoided. The documentation suggests that instead of using `RawConfigParser`, we should use `ConfigParser` and set `interpolation=None` at instantiation instead.
|
Given that this is merged, everyone's still welcome to review it, but it doesn't need to be a task for them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation for
configparser.RawConfigParser(https://docs.python.org/3/library/configparser.html#configparser.RawConfigParser), this is a legacy API call that allows for non-string section names, option names, and values via the unsafeadd_sectionandsetmethods. We don't use those methods, but it's overall still a legacy compatibility and should be avoided.The documentation suggests that instead of using
RawConfigParser, we should useConfigParserand setinterpolation=Noneat instantiation instead.