Update bodyfetcher.py #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds additional debugging information to api_quota missing message
teward
previously requested changes
Apr 24, 2017
| @@ -306,6 +306,7 @@ def make_api_call_for_site(self, site): | |||
| if GlobalVars.api_backoff_time < time.time() + 12: # Add a backoff of 10 + 2 seconds as a default | |||
| GlobalVars.api_backoff_time = time.time() + 12 | |||
| message_hq += " Backing off on requests for the next 12 seconds." | |||
| message_hq += " Previous URL: `{}`".format(url) | |||
There was a problem hiding this comment.
This can be added simply to the prior message, without its own line.
message_hq += " Backing off on requests for the next 12 seconds. Previous URL: `{}`".format(url)
That's such an example. (I don't think we need to add a dedicated += if we can just use the existing one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional message when an
api_quotamissing message occurs. It will show the lasturlthat was sent.