Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More uniform exception logging helpers #7213

Merged
merged 7 commits into from
Jul 31, 2022
Merged

Conversation

makyen
Copy link
Contributor

@makyen makyen commented Jul 29, 2022

This started out with just intending to add some additional debug logging of exception in the chat init sequence in order to be able to get a better idea of what was happening during that process when SE was down. However, prior to that, I made changes to the logging helper functions, log(), log_exception(), and log_current_exception() to have more descriptive argument names, more consistency, etc.

This PR does:

  • More consistent argument name level -> log_level in log_exception and log_current_exception() to match log()
  • More descriptive argument name in all three functions f->and_file to indicate the log is also being recorded in a file.
  • Add ability to specify log_level and and_file for log_current_exception()`
  • Use log_current_exception() for log_exception(*sys.exc_info()) throughout the code.
  • Add ErrorLogs.add_current_exception
  • Add debug level logging of exceptions which are caught in the chat room init process.

In addition to CI testing, a minimal amount of testing (basically just a smoke test) was performed in the Makyen Test 02 room.

@makyen makyen merged commit 51deb5b into master Jul 31, 2022
@makyen makyen deleted the Mak-more-logging-for-chat-login branch July 31, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant