More uniform exception logging helpers #7213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started out with just intending to add some additional debug logging of exception in the chat init sequence in order to be able to get a better idea of what was happening during that process when SE was down. However, prior to that, I made changes to the logging helper functions,
log()
,log_exception()
, andlog_current_exception()
to have more descriptive argument names, more consistency, etc.This PR does:
level
->log_level
inlog_exception
andlog_current_exception()
to matchlog()
f
->and_file
to indicate the log is also being recorded in a file.log_level
andand_file
for log_current_exception()`log_current_exception()
forlog_exception(*sys.exc_info())
throughout the code.ErrorLogs.add_current_exception
In addition to CI testing, a minimal amount of testing (basically just a smoke test) was performed in the Makyen Test 02 room.