Add private room for SagarV and Smoke Detector on meta chat #973
Conversation
added a new room
|
Could you document here the rationale for adding another room on Meta? Smoke Detector is already in the Tavern (and posts are periodically archived to Chimney). If this is just for your personal needs, you can set up Smokey to ping you in chat with |
|
@tripleee to be fair, !!/notify is rather broken. |
|
For the record, the Travis failure is just the run-of-the-mill |
|
I'd also like to know the rational behind this. |
tripleee
changed the title
ws.py
Outdated
| @@ -197,6 +197,10 @@ def check_socket_connections(): | |||
| "room": GlobalVars.wrap.get_room("388"), | |||
| "unwantedReasons": [] | |||
| }, | |||
| { "sites": ["meta.stackexchange.com"], | |||
There was a problem hiding this comment.
flake8 dislikes this, but the fix should be trivial -- just add a newline after the opening brace and reindent.
ws.py
Outdated
| @@ -197,6 +197,10 @@ def check_socket_connections(): | |||
| "room": GlobalVars.wrap.get_room("388"), | |||
| "unwantedReasons": [] | |||
| }, | |||
| { "sites": ["meta.stackexchange.com"], | |||
| "room": GlobalVars.wrap.get_room("1121"), | |||
There was a problem hiding this comment.
I think you will need to use wrapm rather than wrap to get the correct room.
Hopefully finally appease flake8
Gaah, missed one. `flake8`, happy now?
Codecov Report
@@ Coverage Diff @@
## master #973 +/- ##
=======================================
Coverage 64.22% 64.22%
=======================================
Files 6 6
Lines 1764 1764
=======================================
Hits 1133 1133
Misses 631 631
Continue to review full report at Codecov.
|
|
Rejected due to lack of explanation both here and in CHQ |
added a new private room only for reports. no other discussion.