Rubocop and SD route bugfix

Charcoal-SE · Mar 18, 2019 · a74cb0b · a74cb0b
1 parent b2bab68
commit a74cb0b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
@@ -90,7 +90,7 @@ def redis_log_request
       request.set_header 'redis_logs.log_key', redis_log_key
       request.set_header 'redis_logs.timestamp', @request_time
       request.set_header 'redis_logs.request_id', request.uuid
-      unless session[:redis_log_id].present? || is_smokey_route?
+      unless session[:redis_log_id].present? || smokey_route?
         session[:redis_log_id] = SecureRandom.base64
         session[:redis_log_id] = SecureRandom.base64 while redis.exists("session/#{session[:redis_log_id]}")
       end

diff --git a/app/jobs/redis_log_job.rb b/app/jobs/redis_log_job.rb
@@ -9,7 +9,7 @@ class RedisLogJob < ApplicationJob
       begin
         i.to_yaml
       rescue
-        ""
+        ''
       end
     end
   end

diff --git a/config/initializers/redis_logging.rb b/config/initializers/redis_logging.rb
@@ -4,7 +4,9 @@
 
 REDIS_LOG_EXPIRATION = 1.day.seconds.to_i
 
-def log_timestamps(ts, status:, action:, controller:, format:, method:, view_runtime:, db_runtime:, path:, uuid:) # rubocop:disable Metrics/ParameterLists
+# rubocop:disable Metrics/ParameterLists
+def log_timestamps(ts, status:, action:, controller:, format:, method:, view_runtime:, db_runtime:, path:, uuid:)
+  # rubocop:enable Metrics/ParameterLists
   redis = redis(logger: true)
   return if path.nil?
   path = Rails.sensible_routes.match_for(path)&.path || path.split('?').first