'Conflicting feedback across revisions' triggers on posts with no feedback

[Undo1]

In this example, the first post/revision had tp feedback while the second had no feedback at the time of the chat message being posted.

Looks like an issue in this call:

conflicting_revisions = Post.where(link: link)
                                               .where.not(id: id)
                                               .where('is_tp != ? or is_fp != ?', is_tp, is_fp)

triggering based on is_tp != true (due to complete lack of feedback).

[quartata]

I had a different predicate initially, which was a bit clunkier in terms of interactions wirh NAAs but didn't do this. Art suggested changing it to the current one -- I pointed out that this would occur, but at the time I think we were both OK with it because it didn't seem that common.

[quartata]

#280 for the full discussion

[ArtOfCode-]

I think I also misunderstood exactly what case it would trigger on :P

[Undo1]

Apparently I "fixed" this by just shutting off the conflicting feedback warnings in 571cbe7. Ping @quartata - think this is worth fixing?

[thesecretmaster]

@quartata Pinging again re: above

[ArtOfCode-]

Closing as no longer relevant with these messages disabled.