Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursed link to metasmoke API documentation #57

Closed
tripleee opened this issue Dec 5, 2019 · 3 comments
Closed

Cursed link to metasmoke API documentation #57

tripleee opened this issue Dec 5, 2019 · 3 comments
Labels

Comments

@tripleee
Copy link
Member

tripleee commented Dec 5, 2019

The page https://charcoal-se.org/ms has a link ostensibly to the metasmoke API documentation which doesn't work correctly. The first time I click, nothing happens; then, it displays a 404 page (the location bar shows /API-documentation where the link should apparently be to /ms/API-documentation). What's worse, clicking through causes the back button to stop working, and instead displaying [object Object] on every page on the site.

Hovering over the link shows me https://charcoal-se.org/ms/API-Documentation and copying that URL to the location bar allows me to view the destination page just fine. There's something wrong with the link itself.

The page source displays

<a href="API-Documentation">here</a>

I can't always repro, but entering the main site's start page, clicking through to the metasmoke wiki from near the end of the page, and then clicking the "here" link to the API documentation seems to repro every time for me (MacOS Mojave, Chrome 78.0.3904.97)

@tripleee tripleee changed the title Cursed link to metasmoke wiki Cursed link to metasmoke API documentation Dec 5, 2019
@ArtOfCode-
Copy link
Member

[status-norepro], but I've edited the link to an absolute URL so it should always work.

@makyen
Copy link
Contributor

makyen commented Dec 5, 2019

I'm able to reproduce this in Firefox using the instructions in the last paragraph of the report. Well, actually, the following sequence:

  1. Go to the SD Wiki link from the pinned Project Links in CHQ.
  2. Click on the Home icon in the upper left of the page.
  3. Scroll to the bottom of the page and click the "metasmoke wiki" link, which is the last couple of words in the last paragraph.
  4. Click on "here", which is the last word in the last paragraph. This causes the loading animation to happen, but no change in the page.
  5. Click on the same "here" again. This results in a 404 page.
  6. Click on the browser's "Back" button. This results in [Object Object]

Every time I've tried this sequence, I've ended up with the erroneous result.

Prior to trying that sequence, I tried several times to duplicate the problem, without success.

@makyen makyen reopened this Dec 5, 2019
@makyen makyen transferred this issue from Charcoal-SE/metasmoke Dec 5, 2019
@makyen makyen added the bug label Dec 5, 2019
iBug added a commit that referenced this issue Dec 5, 2019
SmokeDetector added a commit that referenced this issue Dec 5, 2019
Changed: [8e71723] iBug: Should probably solve the issue in #57
@iBug
Copy link
Member

iBug commented Dec 5, 2019

Tried @makyen 's instruction and it did reproduce the issue (Chrome 78), doesn't seem to be specific to any browser. I identified a possible cause and pushed a fix (that I believe is correct).

Though I believe the ultimate fix is somewhere in the JavaScript that handles page transition. The trailing slash in the URL needs to be correctly added where expected. Haven't looked into that, though.

Edit: Looks like this file needs a patch.

@iBug iBug closed this as completed Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants