Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FDSC 1.4.1 Bug: "False Positive" attempts without API key open MetaSmoke site for getting the key, but not the "Enter Code" window. #10

Closed
teward opened this issue Nov 1, 2016 · 3 comments
Closed

FDSC 1.4.1 Bug: "False Positive" attempts without API key open MetaSmoke site for getting the key, but not the "Enter Code" window. #10

teward opened this issue Nov 1, 2016 · 3 comments

Comments

@teward
Copy link
Member

teward commented Nov 1, 2016

We initially reverted in 1.3.1 because we couldn't auth with 1.2.x. With 1.4.1, the auth issue is fixed... for typical flagging of a post. However, when "False Positive" is selected, and no API key / write token is stored, the MetaSmoke API page where you can authorize the application is displayed, but the prompt window for entering the API code from that MetaSmoke page does not show up.

It shows up for no-write-token flagging, but not "false positive" recording.
@angussidney
Copy link
Member

I think the code which closes the flag dialog after the false positive button is pressed is accidentally closing the input dialog too. Hopefully that should fix it.

@ArtOfCode-
Copy link
Member

@angussidney that's what the afterFlag param is for

@teward
Copy link
Member Author

teward commented Nov 1, 2016

@angussidney @ArtOfCode- Neither of you bumped the version with the change - the updates aren't getting grabbed as such...

teward added a commit to teward/Userscripts that referenced this issue Nov 1, 2016
@teward
Version bump as a result of Charcoal-SE#10
374e639 
No version bump was done so these changes are not caught by userscript update functions.  Bump version accordingly.
@teward teward mentioned this issue Nov 1, 2016
Merged
ferrybig added a commit that referenced this issue Nov 1, 2016
@ferrybig
Merge pull request #11 from teward/master
778fdd5 
Version bump (to 1.4.2) as a result of fix for #10
double-fault added a commit to double-fault/userscripts that referenced this issue Feb 21, 2017
@double-fault
small error, (should) fix issue Charcoal-SE#10 on the website repo
2e37b0f 
Charcoal-SE/charcoal-se.github.io#10 (comment)
j-f1 added a commit that referenced this issue Feb 21, 2017
@j-f1
Merge pull request #42 from Fortunate-MAN/patch-1
7d7b767 
small error, (should) fix issue #10 on the website repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teward @angussidney @ArtOfCode-