Use debug from npm instead of custom debug solutions #84
Conversation
|
@ArtOfCode- Why? |
|
@j-f1 Mostly because in all likelihood I did it like that for a reason |
|
^ FDSC approved, other script authors should look at their own stuff |
There was a problem hiding this comment.
Regarding Spamtracker:
I think this will improve spam tracker, the only confusing factor I see is the fact that debug is now placed as the rootlogger, so it is harder to actually see what messages are the debug category. Also, because the fact that this PR hides the "error" messages by default, it makes debugging harder, in the case something goes wrong with the script.
| /* eslint-disable max-nested-callbacks */ | ||
|
|
||
| (function () { | ||
| "use strict"; | ||
| const createDebug = typeof unsafeWindow === "undefined" ? window.debug : unsafeWindow.debug || window.debug; |
There was a problem hiding this comment.
Wouldn't this be functionally equal, but cleaner?
const createDebug = (unsafeWindow || window).debug;
There was a problem hiding this comment.
@Cerbrus If unsafeWindow is undefined, that’ll throw a ReferenceError.
There was a problem hiding this comment.
Aw shoot, you're right @j-f1. That's a shame.
|
@ferrybig Does Spamtracker work again? |
|
@j-f1 No, Still the same error.
https://chat.stackexchange.com/transcript/message/37405109#37405109 |
|
@ferrybig Are you using Greasemonkey? |
|
@j-f1 tamper monkey on Google chrome. Could it be the case that it works for you because another userscript is importing the debug library in the window variable, as haven't installed the other userscripts |
spamtracker/spamtracker.user.js
Outdated
| "use strict"; | ||
| const createDebug = typeof unsafeWindow === "undefined" ? window.debug : unsafeWindow.debug || window.debug; | ||
| const createDebug = typeof orginalWindow === "undefined" ? window.debug : orginalWindow.debug || window.debug; |
|
I’m planning to merge this today. Any objections? |
This uses npm’s
debugmodule to manage logging.