Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use JSON.stringify for the params in requestToApi #25

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Fix: Use JSON.stringify for the params in requestToApi #25

merged 1 commit into from
Aug 22, 2018

Conversation

ad1992
Copy link
Contributor

@ad1992 ad1992 commented Aug 22, 2018

Fixes #24

@coveralls
Copy link

Pull Request Test Coverage Report for Build 91

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.272%
Totals Coverage Status
Change from base Build 90: 0.0%
Covered Lines: 110
Relevant Lines: 144
💛 - Coveralls

@CharlesMangwa
Copy link
Owner

Merging this right now. Thanks for the heads up @ad1992! 🙂

@CharlesMangwa CharlesMangwa merged commit 523b7de into CharlesMangwa:master Aug 22, 2018
@ad1992 ad1992 mentioned this pull request Aug 22, 2018
Merged
@ad1992 ad1992 deleted the aakansha-fix-api branch August 22, 2018 18:24
@ad1992
Copy link
Contributor Author

ad1992 commented Aug 22, 2018

Thanks @CharlesMangwa for merging this. I am currently using this library in one of my projects so can you also do a version bump or this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ad1992 @coveralls @CharlesMangwa