Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add try catch in returnedData in requestToApi #28

Merged
merged 1 commit into from Sep 11, 2018
Merged

Add try catch in returnedData in requestToApi #28

merged 1 commit into from Sep 11, 2018

Conversation

ad1992
Copy link
Contributor

@ad1992 ad1992 commented Aug 26, 2018 •
edited

fixes #27

@coveralls
Copy link

Pull Request Test Coverage Report for Build 97

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 73.521%
Totals Coverage Status
Change from base Build 96: 0.2%
Covered Lines: 131
Relevant Lines: 153
💛 - Coveralls

@ad1992 ad1992 changed the title Add try catch in returnedData in requestToApi, fixes #27 Add try catch in returnedData in requestToApi Aug 26, 2018
@ad1992
Copy link
Contributor Author

ad1992 commented Aug 27, 2018

@CharlesMangwa please review

@ad1992
Copy link
Contributor Author

ad1992 commented Sep 1, 2018

@CharlesMangwa any update ?

@CharlesMangwa
Copy link
Owner

@ad1992 Sorry for the delay, I wasn't available for OSS this last couple of days. Thank you for the heads up about this issue, merging now! 👍

@CharlesMangwa CharlesMangwa merged commit 35b8449 into CharlesMangwa:master Sep 11, 2018
@ad1992
Copy link
Contributor Author

ad1992 commented Sep 15, 2018

@CharlesMangwa can you do a minor version bump with this fix ?

@ad1992
Copy link
Contributor Author

ad1992 commented Sep 19, 2018

@CharlesMangwa ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ad1992 @coveralls @CharlesMangwa