fix issue with receivers being in the wrong location and enable multidex #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaikuB
commented
Jul 19, 2019
| @@ -39,6 +39,7 @@ android { | |||
| versionCode flutterVersionCode.toInteger() | |||
| versionName flutterVersionName | |||
| testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" | |||
| multiDexEnabled true | |||
There was a problem hiding this comment.
multidex needs to be enabled as per https://developer.android.com/studio/build/multidex
MaikuB
commented
Jul 19, 2019
| @@ -39,5 +34,11 @@ | |||
| <category android:name="android.intent.category.LAUNCHER"/> | |||
| </intent-filter> | |||
| </activity> | |||
| <receiver android:name="com.dexterous.flutterlocalnotifications.ScheduledNotificationBootReceiver"> | |||
There was a problem hiding this comment.
receivers weren't placed in the right location
MaikuB
commented
Jul 19, 2019
| @@ -3,12 +3,7 @@ | |||
|
|
|||
| <!-- Local Notifications --> | |||
| <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED"/> | |||
There was a problem hiding this comment.
just a note that there are other permissions mentioned in the readme that hadn't been added here
MaikuB
commented
Jul 19, 2019
| @@ -18,6 +18,7 @@ allprojects { | |||
| subprojects { | |||
| project.configurations.all { | |||
| resolutionStrategy.eachDependency { details -> | |||
| // not sure why the first condition has been added. AndroidX is suppose to replace the support libraries | |||
There was a problem hiding this comment.
see question here. i suspect that you should be able to remove the first if block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created a PR to make it easier to see what changes are needed