Add [ApiController] and set ID convention correctly

CharlieJKendall · Feb 22, 2020 · f0022db · f0022db
1 parent 632bce8
commit f0022db
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 14 deletions.
diff --git a/src/Snoozle/Abstractions/BaseResourceConfigurationBuilder.cs b/src/Snoozle/Abstractions/BaseResourceConfigurationBuilder.cs
@@ -134,24 +134,21 @@ protected virtual void SetPropertyConfigurationDefaults()
         /// </summary>
         protected virtual void SetConventionsForProperties()
         {
-            TPropertyConfiguration config;
+            var resourceIdName = typeof(TResource).Name.ToLowerInvariant() + "id";
+            var resourceIdPropertyConfig = _propertyConfigurations.FirstOrDefault(prop => prop.Key.ToLower() == resourceIdName).Value;
+            var idPropertyConfig = _propertyConfigurations.FirstOrDefault(prop => prop.Key.ToLower() == "id").Value;
 
-            // Set column called [resource_type_name]Id to primary identifier (i.e. Person -> PersonId)
-            var idPropName = typeof(TResource).Name.ToLowerInvariant() + "id";
-            config = _propertyConfigurations.FirstOrDefault(prop => prop.Key.ToLower() == idPropName).Value;
-
-            if (config != null)
+            if (idPropertyConfig != null)
             {
-                config.IsPrimaryResourceIdentifier = true;
+                // Set column called Id to primary identifier
+                idPropertyConfig.IsPrimaryResourceIdentifier = true;
+                idPropertyConfig.IsReadOnly = true;
             }
-
-            // Set column called Id to primary identifier
-            config = _propertyConfigurations.FirstOrDefault(prop => prop.Key.ToLower() == "id").Value;
-
-            if (config != null)
+            else if (resourceIdPropertyConfig != null)
             {
-                _propertyConfigurations.Values.ToList().ForEach(prop => prop.IsPrimaryResourceIdentifier = false);
-                config.IsPrimaryResourceIdentifier = true;
+                // Set column called [resource_type_name]Id to primary identifier (i.e. Person -> PersonId)
+                resourceIdPropertyConfig.IsPrimaryResourceIdentifier = true;
+                resourceIdPropertyConfig.IsReadOnly = true;
             }
         }
 

diff --git a/src/Snoozle/Core/RestResourceController.cs b/src/Snoozle/Core/RestResourceController.cs
@@ -12,6 +12,7 @@
 namespace Snoozle.Core
 {
     [Route("api/[controller]")]
+    [ApiController]
     public sealed class RestResourceController<TResource> : ControllerBase
         where TResource : class, IRestResource
     {