Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change codepage name 'mac-centraleurope' to 'x-mac-ce' #75

Closed
rstm-sf opened this issue Nov 6, 2019 · 3 comments · Fixed by #81
Closed

Change codepage name 'mac-centraleurope' to 'x-mac-ce' #75

rstm-sf opened this issue Nov 6, 2019 · 3 comments · Fixed by #81
Milestone
2.3

Comments

@rstm-sf
Copy link
Collaborator

rstm-sf commented Nov 6, 2019

Hello!

Change codepage name 'mac-centraleurope' to 'x-mac-ce'.

Because in .NET so (see code-page-identifiers or EncodingTable.Data.cs).
@rstm-sf rstm-sf mentioned this issue Nov 6, 2019
Merged
@304NotModified
Copy link
Member

If we do Encoding.GetEncoding, will the latter retrieve an encoding? And the first?

@rstm-sf
Copy link
Collaborator Author

rstm-sf commented Nov 9, 2019

If we do Encoding.GetEncoding, will the latter retrieve an encoding?

Yes (see doc or example-on-sharplab).

And the first?

I think this is true for non win32 APIs

This was referenced Nov 9, 2019
Open
Merged
Closed
@rstm-sf
Copy link
Collaborator Author

rstm-sf commented Nov 10, 2019

Now it's part #78

@rstm-sf rstm-sf closed this as completed Nov 10, 2019
304NotModified pushed a commit that referenced this issue Nov 10, 2019
@rstm-sf @304NotModified
Fix codepage name 'mac-centraleurope' to 'x-mac-ce' (#81)
7d1b0f3 
* Add test for codepage name 'x-mac-ce'

* Fix name 'mac-centraleurope' to 'x-mac-ce' (#75)
@304NotModified 304NotModified added this to the 2.3 milestone Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3
Development

Successfully merging a pull request may close this issue.

Fix codepage name 'mac-centraleurope' to 'x-mac-ce'
2 participants
@rstm-sf @304NotModified