Call chartViewDidEndPanning on when *panning* is ended #4271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this PR introduced a regression. The |
|
In the latest version it looks like that But, panning is not always dragging. |
jonnymacs
pushed a commit
to atm-com/Charts
that referenced
this pull request
Jul 9, 2020
|
reverted. |
liuxuan30
added a commit
that referenced
this pull request
Dec 31, 2021
…ent_scrollView_on_dragging Revert #4271 and disable parent scroll view on dragging
taykay08
added a commit
to bigskyhealth/Charts
that referenced
this pull request
Apr 18, 2022
…ase-master-update * 'master' of https://github.com/danielgindi/Charts: bump pod version Update project settings to support publishing pod Revert ChartsOrg#4271 and disable parent scroll view on dragging
rcblue
added a commit
to rcblue/Charts
that referenced
this pull request
Jan 6, 2023
rcblue
added a commit
to rcblue/Charts
that referenced
this pull request
Jan 6, 2023
…ent_scrollView_on_dragging Revert ChartsOrg/Charts#4271 and disable parent scroll view on dragging
mmazzei
pushed a commit
to mmazzei/Charts
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
Straighten the semantics of the event.
Implementation Details 🚧
Currently the relatively new protocol method is called in the end of the gesture, even if the gesture does not mean "pan". This could cause unexpected bugs.