Fix for issue where data points are not highlighted #4613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct filter predicate used when calling the `partitioningIndex` func while calculating the `entriesForXValue`
|
Has this been merged? I'm still seeing this issue |
|
waiting for merge |
|
Same, otherwise 4.0 is useless... |
|
Please merge... |
|
Closed in favour of #4721 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
Fixes #4609 and possibly also #4579
Goals ⚽
Improve the highlighting / selection behavior of line charts
Implementation Details 🚧
The
entriesForXValuefunc finds the data entries for a given x-axisvalue. It used an optimization where it would do a binary search to find
the first matching entry then take a slice of data stopping when no more
entries matched.
The optimized code uses the
partitionIndexfunction but the filter predicateused in this function was incorrect.
Testing Details 🔍
Tested by altering the demo project to use the forked version of the code and confirming the broken behaviour works after the fix is applied