Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Privacy Manifest #5141

Merged
merged 7 commits into from
Feb 15, 2024
Merged

Add Privacy Manifest #5141

merged 7 commits into from
Feb 15, 2024

Conversation

wlxo0401
Copy link
Contributor

@wlxo0401 wlxo0401 commented Jan 8, 2024

Issue Link πŸ”—
#5131

Goals ⚽
add Privacy Manifest

Implementation Details 🚧

Testing Details πŸ”

I checked with CodeBase and thought 'DGCharts' had nothing to add to PrivacyInfo.

I think it will take a lot of people's opinions and tests to complete this.

Please check my PR and feel free to comment.

This resolves #5131

@pmairoldi pmairoldi self-assigned this Jan 10, 2024
@wlxo0401
Copy link
Contributor Author

Oh, my God. How do I fix this? "Some checks were not successful"

@wlxo0401 wlxo0401 mentioned this pull request Jan 26, 2024
1 task
@pmairoldi
Copy link
Collaborator

If you want to test it out locally you can run pod lib lint. I think the path is wrong in the podspec. Seems like there is an extra s. Should be Source instead of Sources no?

Process completed with exit code 1.
@wlxo0401
Copy link
Contributor Author

If you want to test it out locally you can run pod lib lint. I think the path is wrong in the podspec. Seems like there is an extra s. Should be Source instead of Sources no?

I changed it from
s.resource_bundles = {"DGCharts" => ["Sources/Charts/PrivacyInfo.xcprivacy"]}

to

s.resource_bundles = {"DGCharts" => ["Source/Charts/PrivacyInfo.xcprivacy"]}

@wlxo0401
Copy link
Contributor Author

wlxo0401 commented Jan 26, 2024

@pmairoldi Thank you. we caught the error.

@wlxo0401
Copy link
Contributor Author

wlxo0401 commented Feb 1, 2024

I didn't set a target for PrivacyInfo, so I added a setting.

I don't know if this is necessary, but please review it.

@pmairoldi pmairoldi merged commit 0837484 into ChartsOrg:master Feb 15, 2024
8 checks passed
@wlxo0401
Copy link
Contributor Author

@pmairoldi

Thank you for accepting the PR.

However, I think it is also necessary to make sure that this is applied properly as Apple demanded.

And I think other users will have to check it out a lot.

If this is wrong, an immediate response may also be needed..

When is the new release that includes this??

Once again, thank you for your care in a busy time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Privacy Manfiest
3 participants