Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying git branch of extensions #853

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shadyvb
Copy link
Collaborator

@shadyvb shadyvb commented Jan 7, 2021

Resolves #852

I don't really have Ruby experience, but this does seem to work. Happy to update/tweak as needed.

@shadyvb
Copy link
Collaborator Author

shadyvb commented Jan 15, 2021

Another reason for adoption to this is the tester extension being broken when it is updated while project codebases are not, just hit this myself, had to revert the extension for phpunit to work.

@BronsonQuick
Copy link
Member

@shadyvb Nice work Sir. This looks good to me. Can you please update the documentation to cover this change as well please then I'm happy to test it and merge it. Thank you!

@BronsonQuick
Copy link
Member

I was having another think about this PR this morning and I am wondering if instead of the -b branch-name, it might be better using the commit hash?

@shadyvb
Copy link
Collaborator Author

shadyvb commented Apr 19, 2021

@BronsonQuick this is a bit more restrictive, if I'm specifying a branch name I'd probably want to receive updates to it too.

Maybe we can support both ? repo@branch and repo#commit ? a bit more logic to add though, as it'll require a second conditional git checkout call.

@BronsonQuick
Copy link
Member

@shadyvb Supporting both sounds good to me Sir! I've not been one to maintain branches as it doesn't take long for branches to diverge and not be maintained. I'm happy for us to support both though and other contributors to extensions can maintain the branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow installing specific versions of extensions
2 participants