-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallels/Arm tweaks #941
Parallels/Arm tweaks #941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for making a start on this! Most appreciated. I've left a few comments to follow up on as I think we might be able to simplify it 🤞🏻
It might be related to using Puppet 7
…On Sun, 26 Dec 2021 at 22:28, Bronson Quick ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In puppet/modules/chassis/lib/puppet/parser/functions/sz_extensions.rb
<#941 (comment)>:
> @@ -1,15 +1,15 @@
require "/vagrant/puppet/chassis"
module Puppet::Parser::Functions
+ newfunction(:chassis_get_global_extensions, :type => :rvalue) do |args|
That's a weird one! No worries. It won't affect anything for other
providers so I'm happy to leave this then!
—
Reply to this email directly, view it on GitHub
<#941 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAOLZ52P6IC2ZWYCCUDRHLUS6JILANCNFSM5KY7DRSQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
current result of this PR on Parallels/Arm64:
|
That's running on Puppet 5
|
Ahh right. I'm wonder if the submodules update I merged in from you in ES caused that. Can you please try changing the ES extension to be a commit before the submodule update and see if that works? If that's the case then I'll need to revert that. I'll try a fresh provision of Chassis just with the ES extension now as well. |
Nope because then it'll fail complaining Ubuntu 20 isn't supported in the Java puppet config |
No worries. I just did a fresh provision with ES and didn't have any issues so that's all good as you mentioned. I did notice:
I didn't realise Cavalcade was using that Exec function so I'll open a new issue for adding that back and I'll fix that now. |
@BronsonQuick that helped, it progresses to this point now:
|
this is my test config btw: paths:
base: ..
content: content
wp: wordpress
hosts:
- siemens.local
_mode: base
# Define database prefix, since we have tests as well
database:
name: wordpress
user: wordpress
password: vagrantpassword
prefix: wp_
# Define the extensions we want
extensions:
- chassis/xdebug
- chassis/tester
- chassis/sequelpro
- chassis/cavalcade
- chassis/mailhog
- chassis/memcache
- chassis/phpcs
- chassis/chassis_openssl
- chassis/redis
- chassis/chassis_elasticsearch
- chassis/runkit7
elasticsearch:
repo_version: '7.x'
version: '7.9.3'
host: '0.0.0.0'
port: 9200
timeout: 10
instances:
- 'es'
jvm_options:
- '-Xms256m'
- '-Xmx256m' |
@tomjn That's getting super close! 🕺 One thing to confirm, is your config file in the root directory? Because paths only work if the config is in the root directory. |
@BronsonQuick that did the trick, I did another |
@tomjn That's awesome news! Nice work Sir! |
I pulled this to test locally on a fresh M1 system, and I'm stalling out due to an unavailable box:
This was with a fresh checkout of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: Tom instructed me to try base box mode (which I hadn't known about, thanks!) and with this config.local.yaml
# config.local.yaml
_mode: base
I was able to get to the WP login screen successfully 👍 🚀 ✅ And it runs fast!
I'll defer to @BronsonQuick but this is working for me, thanks for taking this on @tomjn
@@ -38,7 +38,6 @@ if [[ ! -f /etc/chassis-updated ]]; then | |||
# Update apt | |||
sudo apt-get update | |||
|
|||
# Install/Upgrade Puppet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I am a stupidhead 😂 I probably just missed it when I was adding it back when Puppet v7 didn't play nicely!
Co-authored-by: K Adam White <kadamwhite@users.noreply.github.com>
I'm struggling to find the bandwidth to write docs for this, the general gist is:
Where that goes and how descriptive it needs to be to fit into the Chassis docs? ¯\_(ツ)_/¯ |
As I understand it, the docs needing to be written are the blocker for this, I'm more than happy for someone to pick that up, I am not a blocker for this |
Hey @tomjn, the docs go in the |
I've added a separate issue for me to do the docs: #953 I'll merge this in and type up some docs now. Thanks again @tomjn and @kadamwhite 🙌🏻 |
@BronsonQuick did you mean to merge this PR? I'm not seeing equivalent commits merged elsewhere |
@tomjn I did hit merge this morning and it looks like it didn't go through. I had two other PRs timing out on their checks too so I'm guessing something was up with Github. Thanks for the heads up! Let me try that again! |
Fixes some issues on M1 Macs and Parallels