Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub runner docker images for newer Ubuntus #197

Open
6 of 7 tasks
kwabenantim opened this issue Dec 5, 2023 · 8 comments
Open
6 of 7 tasks

Create GitHub runner docker images for newer Ubuntus #197

kwabenantim opened this issue Dec 5, 2023 · 8 comments

Comments

@kwabenantim
Copy link
Member

kwabenantim commented Dec 5, 2023

Summary
Create images with dependency versions for:

Tasks

  • Build docker image for chaste/runner:kinetic.portability-dev.
  • Build docker image for chaste/runner:lunar.portability-dev.
  • Build docker image for chaste/runner:mantic.portability-dev.
  • Modify boost modulefiles in old portability images to set FindBoost.cmake variables.
  • Fix workflows to use FindBoost.cmake variables from modulefiles.
  • Write developer documentation on building and testing new dependency versions (https://github.com/Chaste/developer_wiki/wiki/Portability-Testing)
  • Fix cvector errors.

PRs

Related Issues

@kwabenantim kwabenantim self-assigned this Dec 5, 2023
@kwabenantim kwabenantim changed the title Create GitHub runner docker image for Ubuntu 23.10 dependencies Create GitHub runner docker images for newer Ubuntus Dec 5, 2023
@kwabenantim
Copy link
Member Author

Currently, system images don't configure correctly because -DBoost_NO_BOOST_CMAKE and -DBoost_NO_SYSTEM_PATHS are set directly in CI workflows. Moving the options into the modulefiles will allow images to set them ON and OFF as required.

@kwabenantim
Copy link
Member Author

Getting maybe-uninitialized errors with GCC 13.2.0 on Ubuntu 23.10 Mantic Minotaur: https://github.com/Chaste/dependency-modules/actions/runs/7539367160/job/20521728238

@mirams
Copy link
Member

mirams commented Jan 16, 2024

Worth a look to see if the compiler is correct, sometimes it is and sometimes it isn't for these sort of warnings. Probably don't want to disable that warning globally anyway, it is a useful one!

@kwabenantim

This comment was marked as outdated.

@kwabenantim
Copy link
Member Author

kwabenantim commented Jan 16, 2024

Worth a look to see if the compiler is correct, sometimes it is and sometimes it isn't for these sort of warnings. Probably don't want to disable that warning globally anyway, it is a useful one!

Thanks @mirams. It is probably an issue with boost configuration in this case.

@kwabenantim
Copy link
Member Author

It turns out boost is configuring properly. The same error occurs in the base Ubuntu 23.10 Mantic Minotaur image without the modulefiles.

kwabenantim added a commit that referenced this issue Jan 17, 2024
kwabenantim added a commit that referenced this issue Jan 23, 2024
@kwabenantim
Copy link
Member Author

kwabenantim commented Jan 23, 2024

All portabilities pass except for the new ones - Lunar (gcc 12) and Mantic (gcc 13).

The configure step completes okay, but the build step throws maybe-uninitialized errors.

https://github.com/Chaste/Chaste/actions/runs/7623994326

@MILeach
Copy link
Contributor

MILeach commented Feb 13, 2024

@fcooper8472 to investigate c vector errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants