-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support VTK 9.x #152
Support VTK 9.x #152
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #152 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 980 980
Lines 47842 47843 +1
=========================================
+ Hits 47842 47843 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
Also tested on 22.04 (Jammy) with stock VTK 7.1.1 (vtk7-dev).
Had problems installing vtk9-dev without breaking multiple parts of my current Chaste development environment, but that's okay because CLI show it works on a fresh install.
See #36
This approach creates a CMake interface library with no source files which our dependencies are linked against.
This interface library is then linked against chaste libraries and executables.
This allows us to use the modern
target_link_libraries
method of ingesting dependencies, whereas we had previously been relying on populating lists of libraries and include directories, which is a much older CMake pattern.VTK 9 is the first dependency that is no longer compatible with this old way of doing things, but part of the work on modernising our CMake infrastructure will be to migrate all our dependencies over to this new way of doing things.