Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VTK 9.x #152

Merged
merged 11 commits into from
Aug 16, 2023
Merged

Support VTK 9.x #152

merged 11 commits into from
Aug 16, 2023

Conversation

fcooper8472
Copy link
Member

See #36

This approach creates a CMake interface library with no source files which our dependencies are linked against.

This interface library is then linked against chaste libraries and executables.

This allows us to use the modern target_link_libraries method of ingesting dependencies, whereas we had previously been relying on populating lists of libraries and include directories, which is a much older CMake pattern.

VTK 9 is the first dependency that is no longer compatible with this old way of doing things, but part of the work on modernising our CMake infrastructure will be to migrate all our dependencies over to this new way of doing things.

@fcooper8472 fcooper8472 linked an issue Aug 9, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #152 (8a80064) into develop (b7ee62a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop      #152   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          980       980           
  Lines        47842     47843    +1     
=========================================
+ Hits         47842     47843    +1     
Files Changed Coverage Δ
mesh/src/reader/VtkMeshReader.cpp 100.00% <100.00%> (ø)

@fcooper8472 fcooper8472 mentioned this pull request Aug 10, 2023
@fcooper8472 fcooper8472 marked this pull request as ready for review August 11, 2023 16:57
Copy link
Contributor

@jmpf jmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Also tested on 22.04 (Jammy) with stock VTK 7.1.1 (vtk7-dev).
Had problems installing vtk9-dev without breaking multiple parts of my current Chaste development environment, but that's okay because CLI show it works on a fresh install.

@fcooper8472 fcooper8472 merged commit f21282c into develop Aug 16, 2023
34 checks passed
@fcooper8472 fcooper8472 deleted the vtk-9 branch August 16, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support VTK 9.x
3 participants