Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auatay ticket 2987 ode edges #56

Merged
merged 211 commits into from
Jun 12, 2023
Merged

Conversation

BJackal
Copy link
Contributor

@BJackal BJackal commented Jan 17, 2023

Recent developments to the develop branch have been merged into the auatay branch for cell edge and interior data structures and use. Currently passes all Continuous tests locally and needs to be looked at for being merged into the development branch.

twinkarma and others added 30 commits January 16, 2019 17:46
Need to add algorithm for finding edge neighbours.
@fcooper8472
Copy link
Member

This should hopefully resolve a number of the memory leaks. I'll check back on Monday after the memtest run finishes to see what's left to iron out.

@fcooper8472
Copy link
Member

Update after yesterday's fix: we're down to 5 tests with a memory leak. Making good progress - hoping to have the last memory leaks tracked down today.

@BJackal and @jmpf can we think about another code review meeting ASAP?

Copy link
Member

@fcooper8472 fcooper8472 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one outstanding issue (#106) but this is a good point to get it in to develop.

@@ -51,6 +51,7 @@ AbstractElement<ELEMENT_DIM, SPACE_DIM>::AbstractElement(unsigned index, const s
mIsDeleted(false),
mOwnership(true),
mpElementAttributes(nullptr)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove spaces in this file

@fcooper8472 fcooper8472 merged commit cf4eb01 into develop Jun 12, 2023
7 of 23 checks passed
@fcooper8472 fcooper8472 deleted the auatay_ticket_2987_ode_edges branch June 12, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants