Removing scons and adding an error message #73
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #73 +/- ##
========================================
Coverage 99.99% 99.99%
========================================
Files 931 931
Lines 45865 45865
========================================
Hits 45862 45862
Misses 3 3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Also todo: remove mentions of Scons in code comment instructions. |
|
This looks good to me. |
| @@ -54,13 +54,6 @@ OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||
| * | |||
| * | |||
| * | |||
| * For example: | |||
There was a problem hiding this comment.
This really wants replacing with cmake example rather than just deleting
| @@ -15,19 +15,6 @@ our special binary version of the Triangle/Tetgen format. | |||
| to containing element indices. The presence of this file cuts the calculation cost at mesh load time. | |||
| * If a Chaste format fibre file (.axi or .ortho) is associated with the mesh then this will also be converted to our binary format. | |||
|
|
|||
| === Making the executable(s) === | |||
There was a problem hiding this comment.
This really wants replacing with cmake example rather than just deleting
There was a problem hiding this comment.
I thought naking standalone excutables wasn't possible anymore? @fcooper8472 ? unless I have missunderstood?
There was a problem hiding this comment.
We don't try and make them for people due to difficulties getting compatible cross-platform ones for Linux (used to generate the cardiac executable for download) but still should be able to make them (like ApPredict).
There was a problem hiding this comment.
Yes, it's still absolutely possible. We no longer ship a cardiac executable that you can expect to run portably without compiling it yourself, but the top level apps directory (and indeed the apps directory in any user project) can have standalone executables with their own int main() methods.
There was a problem hiding this comment.
ok but how do we write that in the tutorial?
There was a problem hiding this comment.
This would just be the corresponding instructions but using CMake, I suppose?
scons chaste_libs=1 compile_only=1 exe=1 build=GccOpt apps
would become, assuming you have configured Chaste
make Chaste
or
make MeshConvert
and the build=GccOpt_ndebug equivalent would be passing -DCMAKE_BUILD_TYPE=Release at configure time.
|
addressing the new comments about build properties for cmake in #94 |
Removing scons and adding an error message
This removes Scons code, except for the error message thrown when you try to build with Scons.
However I stilll need to know where to point to, which relates to #59