fix PYBIND11_VTK_TYPECASTER macro and supply typecasters for vtkRende… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rer, vtkOpenGLRenderer
kwabenantim
approved these changes
May 26, 2023
There was a problem hiding this comment.
Thanks @MILeach. Returning vtkRenderer works now for me as well.
Closed
kwabenantim
added a commit
that referenced
this pull request
Jun 9, 2023
fix PYBIND11_VTK_TYPECASTER macro and supply typecasters for vtkRende…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
Tested using Ubuntu 22.04, VTK 7.1.1 and python 3.10.
The PR includes a fix to the PYBIND11_VTK_TYPECASTER macro and then uses this macro to register vtkRenderer and vtkOpenGLRenderer with pybind. Python notebooks using visualisation now correctly display a rendering window, although the window doesn't show any output so this needs further investigation.