Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: row count logic #1371

Merged
merged 1 commit into from
May 10, 2023
Merged

fix: row count logic #1371

merged 1 commit into from
May 10, 2023

Conversation

yanCode
Copy link
Contributor

@yanCode yanCode commented May 10, 2023

this PR fixes the remaing issues in #1359 and 9b1f251

for the details, please see: #1370

@yanCode
Copy link
Contributor Author

yanCode commented May 10, 2023 •
edited

BTW in my fix you can see a line:

dom.value.endsWith("\n");
... + (endWithEmptyLine ? 1 : 0);

because as long as the user inputs any text after \n it will instantly create another new line. so let the UI create this new line in advance to make the UX a little bit more smoothy.

@Yidadaa Yidadaa merged commit 0ad9110 into ChatGPTNextWeb:main May 10, 2023
1 check passed
@yanCode yanCode deleted the fix/textarea-line branch May 10, 2023 03:56
@yanCode yanCode restored the fix/textarea-line branch May 10, 2023 05:29
@yanCode yanCode deleted the fix/textarea-line branch May 13, 2023 00:55
Endlessworld pushed a commit to Endlessworld/ChatGPT-Next-Web that referenced this pull request May 17, 2023
@Yidadaa
Merge pull request ChatGPTNextWeb#1371 from yanCode/fix/textarea-line
0f85029 
fix: row count logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yanCode @Yidadaa