fix: show Vietnamese in its own language #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did a quick test, as you can see here: yanCode@8c7f441 I can make a commit to the codebase via github web UI, which doesn't trigger husky at all. which can likely introduce code format issues as in this PR. |
yanCode
changed the title
Endlessworld
pushed a commit
to Endlessworld/ChatGPT-Next-Web
that referenced
this pull request
May 17, 2023
fix: show Vietnamese in its own language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
In the dropdown list, it should show the language name in its own language. I mean, it should show
Tiếng Việt, rather thanVietnamesein its English translation.Apart from 1, I found lots of formatted code,in app/locales/cs.ts and app/locales/ru.ts resulting many lines of changes in my PR, I did the research, I found these changes in this PR is caused by
lint-staged, I mean for the reason I don't know, these files were committed without running the pre-commit inhusky hook, I tested locally the whole pipeline oflint-stagedworks fine in my local env. maybe these 2 files were directly committed via the webpage of git hub? we'd better make sure no commits can bypass husky hook for git.