Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug #1662 #1665

Merged
merged 1 commit into from
May 21, 2023
Merged

fix: bug #1662 #1665

merged 1 commit into from
May 21, 2023

Conversation

yanCode
Copy link
Contributor

@yanCode yanCode commented May 21, 2023

As in the commit, props.prompts.length should be monitored in useEfffect, otherwise, when search prompt action changes the length of props.prompts, the function inside useEfffect doesn't re-generate at all, which still points to the initial props.prompts, thus the bug comes out..

@Yidadaa Yidadaa merged commit ce75dc5 into ChatGPTNextWeb:main May 21, 2023
1 check passed
xuzhenjun130 pushed a commit to xuzhenjun130/ChatGPT-Next-Web that referenced this pull request May 31, 2023
gaogao1030 pushed a commit to gaogao1030/ChatGPT-Next-Web that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants