fix: bug #1727 #1728
Merged
fix: bug #1727 #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhenjun130
pushed a commit
to xuzhenjun130/ChatGPT-Next-Web
that referenced
this pull request
May 31, 2023
gaogao1030
pushed a commit
to gaogao1030/ChatGPT-Next-Web
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reason of this bug is the
previewcomponent is rendered as{currentStep.value === "select" && (...)which means as long as the value is not
"select", the content inside the()are garbage collected, whenever the value becomestrue, it got re-initialized, values of all states viauseStatewill be initialized again. so it can not remember what it was before.To fix it, only visually hide the
Previewbut let the component instance always be there, by doing that, it can keep these states. the code is:By the way, as the export step doesn't have any state, (aka, a readonly component), so it's fine to keep it as
{currentStep.value === "preview" && ( ... )