fix: updating the array using push in zustand does not actually trigger component updates #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er component updates
…er component updates
|
Delete all commented code, and then i will approve this pr. |
Done. |
alchemist139
pushed a commit
to alchemist139/ChatGPT-Next-Web
that referenced
this pull request
Sep 21, 2023
fix: updating the array using push in zustand does not actually trigger component updates
gaogao1030
pushed a commit
to gaogao1030/ChatGPT-Next-Web
that referenced
this pull request
May 16, 2024
fix: updating the array using push in zustand does not actually trigger component updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the documentation, all states in Zustand are immutable. Therefore, when updating arrays or nested objects, it is recommended to use immutable methods. Mutable methods like
Array.prototype.push()may not be detected by Zustand.Although mutable methods may still work in practice, issues may arise when using performance optimization techniques such as
useCallbackandmemo. This suggests that the component render actually caused by parent components, rather than Zustand.While I am not highly experienced in using Zustand, I personally prefer the immutable approach. If you prefer the mutable approach (as seen in Redux Toolkit), integrating Immer into Zustand may be a viable option.
https://docs.pmnd.rs/zustand/guides/updating-state#normal-approach
https://docs.pmnd.rs/zustand/integrations/immer-middleware