fix: make env PROXY_URL avaliable in Docker container. #4771
Conversation
|
@shawn-mxi-ai is attempting to deploy a commit to the NextChat Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe change in the Changes
Tip New Features and ImprovementsReview SettingsIntroduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. AST-based InstructionsCodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation. Community-driven AST-based RulesWe are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information. New Static Analysis ToolsWe are continually expanding our support for static analysis tools. We have added support for Tone SettingsUsers can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:
Revamped Settings PageWe have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to Miscellaneous
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (5)
Dockerfile (5)
Line range hint
5-5: Pin package versions in apk add commands to ensure reproducibility.- RUN apk add --no-cache libc6-compat + RUN apk add --no-cache libc6-compat=<version>
Line range hint
12-12: Consider consolidating consecutive RUN instructions to reduce the number of layers in the Docker image.- RUN yarn config set registry 'https://registry.npmmirror.com/' - RUN yarn install + RUN yarn config set registry 'https://registry.npmmirror.com/' && \ + yarn install
Line range hint
16-16: Pin package versions in apk add commands to ensure reproducibility.- RUN apk update && apk add --no-cache git + RUN apk update && apk add --no-cache git=<version>
Line range hint
31-31: Use the--no-cacheswitch to avoid the need to use--updateand remove/var/cache/apk/*when done installing packages. Also, pin package versions.- RUN apk update && apk add --no-cache git + RUN apk add --no-cache git=<version>
Line range hint
45-45: Use JSON notation for CMD and ENTRYPOINT arguments to ensure they are interpreted correctly.- CMD if [ -n "$PROXY_URL" ]; then \ - export HOSTNAME="127.0.0.1"; \ - protocol=$(echo $PROXY_URL | cut -d: -f1); \ - host=$(echo $PROXY_URL | cut -d/ -f3 | cut -d: -f1); \ - port=$(echo $PROXY_URL | cut -d: -f3); \ - conf=/etc/proxychains.conf; \ - echo "strict_chain" > $conf; \ - echo "proxy_dns" >> $conf; \ - echo "remote_dns_subnet 224" >> $conf; \ - echo "tcp_read_time_out 15000" >> $conf; \ - echo "tcp_connect_time_out 8000" >> $conf; \ - echo "localnet 127.0.0.0/255.0.0.0" >> $conf; \ - echo "localnet ::1/128" >> $conf; \ - echo "[ProxyList]" >> $conf; \ - echo "$protocol $host $port" >> $conf; \ - cat /etc/proxychains.conf; \ - proxychains -f $conf node server.js --host 0.0.0.0; \ - else \ - node server.js; \ - fi + CMD ["sh", "-c", "if [ -n \"$PROXY_URL\" ]; then \ + export HOSTNAME=\"127.0.0.1\"; \ + protocol=$(echo $PROXY_URL | cut -d: -f1); \ + host=$(echo $PROXY_URL | cut -d/ -f3 | cut -d: -f1); \ + port=$(echo $PROXY_URL | cut -d: -f3); \ + conf=/etc/proxychains.conf; \ + echo \"strict_chain\" > $conf; \ + echo \"proxy_dns\" >> $conf; \ + echo \"remote_dns_subnet 224\" >> $conf; \ + echo \"tcp_read_time_out 15000\" >> $conf; \ + echo \"tcp_connect_time_out 8000\" >> $conf; \ + echo \"localnet 127.0.0.0/255.0.0.0\" >> $conf; \ + echo \"localnet ::1/128\" >> $conf; \ + echo \"[ProxyList]\" >> $conf; \ + echo \"$protocol $host $port\" >> $conf; \ + cat /etc/proxychains.conf; \ + proxychains -f $conf node server.js --host 0.0.0.0; \ + else \ + node server.js; \ + fi"]
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Dockerfile (1 hunks)
Additional Context Used
Hadolint (6)
Dockerfile (6)
5: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>
12: Multiple consecutive
RUNinstructions. Consider consolidation.
16: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>
31: Use the
--no-cacheswitch to avoid the need to use--updateand remove/var/cache/apk/*when done installing packages
31: Pin versions in apk add. Instead of
apk add <package>useapk add <package>=<version>
45: Use arguments JSON notation for CMD and ENTRYPOINT arguments
|
Your build has completed! |
Fix the issue mentioned in #4747.
Summary by CodeRabbit
proxychains.