perf: memorize markdown rendering #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markdown rendering can take time. Use `React.memo` for better performance. The improvement is especially visible if there are complex elements. For example, a `<Chat />` with an output of `如何推导三次方程求根方程？` (which uses latex) now renders in about 5ms, down from ~140ms. Related: ChatGPTNextWeb#302
|
Someone is attempting to deploy a commit to a Personal Account owned by @Yidadaa on Vercel. @Yidadaa first needs to authorize it. |
|
可能需要看一下 React.memo 的实现，如果不小心可能导致 stream 输出时占用 O(N^2) 的内存 |
|
大致看了一下，memo 不会导致 O(N^2) 内存占用。 |
|
我目前已经在代码中提供了一个 lazy load 的 hook，但是还没有实装，建议配合使用，需要把 message 提取成一个单独的组件。 |
|
顺便能否提供一下 memo 前后的 performance 截图对比？ |
|
之前： before.webm之后： after.webm之所以选择 Markdown 是因为它的 props 非常简单，只有一个字符串，容易对比，并且在 profiling 中占用了绝大部分时间。其他组件的 props 有可能直接或间接被各种配置影响。 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
牛逼，马上合入 |
yxl
pushed a commit
to yxl/ChatGPT-Next-Web
that referenced
this pull request
May 4, 2023
perf: memorize markdown rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown rendering can take time. Use
React.memofor better performance.The improvement is especially visible if there are complex elements. For example, a
<Chat />with an output of如何推导三次方程求根方程？(which uses latex) now renders in about 5ms, down from ~140ms.Related: #302