New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add room-leave event #370

Merged
merged 6 commits into from Apr 16, 2017

Conversation

Projects
None yet
5 participants
@lijiarui
Member

lijiarui commented Mar 28, 2017

fix #250

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Mar 29, 2017

Member

Sorry, i cannot merge this because your PR didn't pass any of CI test.

Member

zixia commented Mar 29, 2017

Sorry, i cannot merge this because your PR didn't pass any of CI test.

@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui Mar 29, 2017

Member

Yes, it cannot be merge now, because I should fix #364 first.

And I have fix room.member(), please help to merge it first, thanks

Member

lijiarui commented Mar 29, 2017

Yes, it cannot be merge now, because I should fix #364 first.

And I have fix room.member(), please help to merge it first, thanks

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Mar 29, 2017

Member

Sorry, I have no time to help you about this recently. You need to do it by yourself.

Member

zixia commented Mar 29, 2017

Sorry, I have no time to help you about this recently. You need to do it by yourself.

@zixia zixia changed the title from fix #250 to Bot should be noticed when it was removed from a room #250 Mar 31, 2017

lijiarui added some commits Apr 5, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 5, 2017

Coverage Status

Changes Unknown when pulling f0c8176 on lijiarui:room_leave into ** on Chatie:master**.

coveralls commented Apr 5, 2017

Coverage Status

Changes Unknown when pulling f0c8176 on lijiarui:room_leave into ** on Chatie:master**.

@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui Apr 5, 2017

Member

@zixia maybe it has done...

Member

lijiarui commented Apr 5, 2017

@zixia maybe it has done...

@zixia

Please think of member() method more.

Show outdated Hide outdated src/puppet-web/firer.ts Outdated
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 6, 2017

Coverage Status

Changes Unknown when pulling 77076c7 on lijiarui:room_leave into ** on Chatie:master**.

coveralls commented Apr 6, 2017

Coverage Status

Changes Unknown when pulling 77076c7 on lijiarui:room_leave into ** on Chatie:master**.

@zixia

Please think deeper about the purpose of member() method.

Show outdated Hide outdated src/puppet-web/firer.ts Outdated
@zixia

zixia approved these changes Apr 10, 2017

Ok, I believe it will works.

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Apr 10, 2017

Member

Please get 2 more approving from other contributors as well, then I could be able to merge this.

Thanks!

Member

zixia commented Apr 10, 2017

Please get 2 more approving from other contributors as well, then I could be able to merge this.

Thanks!

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Apr 10, 2017

Member

@lijiarui This is the way of my favorite for using room.member(), which have already used many times in the code base:

https://github.com/Chatie/wechaty/blob/master/src/puppet-web/firer.ts#L319

Member

zixia commented Apr 10, 2017

@lijiarui This is the way of my favorite for using room.member(), which have already used many times in the code base:

https://github.com/Chatie/wechaty/blob/master/src/puppet-web/firer.ts#L319

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 11, 2017

Coverage Status

Changes Unknown when pulling 3e29a82 on lijiarui:room_leave into ** on Chatie:master**.

coveralls commented Apr 11, 2017

Coverage Status

Changes Unknown when pulling 3e29a82 on lijiarui:room_leave into ** on Chatie:master**.

1 similar comment
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 11, 2017

Coverage Status

Changes Unknown when pulling 3e29a82 on lijiarui:room_leave into ** on Chatie:master**.

coveralls commented Apr 11, 2017

Coverage Status

Changes Unknown when pulling 3e29a82 on lijiarui:room_leave into ** on Chatie:master**.

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Apr 11, 2017

Member

The shorter, the better.

Member

zixia commented Apr 11, 2017

The shorter, the better.

@lijiarui lijiarui changed the title from Bot should be noticed when it was removed from a room #250 to add room-leave event Apr 13, 2017

@JasLin

JasLin approved these changes Apr 14, 2017

it' good for me

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Apr 16, 2017

Member

Thanks all!

I can merge this PR now, Cheers!

Member

zixia commented Apr 16, 2017

Thanks all!

I can merge this PR now, Cheers!

@zixia zixia merged commit 1c8fb36 into Chatie:master Apr 16, 2017

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls First build on master at 54.782%
Details
security/snyk No new vulnerabilities
Details

@lijiarui lijiarui deleted the lijiarui:room_leave branch Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment