Wait for smooth scrolling animation to add new message #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we fix the merge conflicts so this can be reviewed and hopefully merged soon? |
|
This seems like a fair fix for me. Basically 'pausing' all message additions during the 'smooth scrolling' effect. |
pajlada
approved these changes
Apr 24, 2021
|
@Pizzabelly could you explain how the other event loop works and if there is race conditions that can happen? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
This fixes a bug in smooth scrolling where scrolling at the same time as a new message was added would cause a visual glitch that looks like the text jumps up and back instantly. To test it you can go in a fast chat and once the message queue fill up, and it starts scrolling to keep your place in the chat, you can scroll up and down to see it.
I'm not sure if this is a good fix because I couldn't fully understand the smooth scrolling code, and this seems like a workaround. So if there is a better way to fix this I'll just close this.