Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anonymous user gets pinged by justinfan64537 #2156

Closed
fourtf opened this issue Nov 4, 2020 · 3 comments · Fixed by #2352
Closed

Anonymous user gets pinged by justinfan64537 #2156

fourtf opened this issue Nov 4, 2020 · 3 comments · Fixed by #2352
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user

Comments

@fourtf
Copy link
Member

fourtf commented Nov 4, 2020

Describe the bug
We anonymously log in using the username justinfan64537. However this allows users to ping all anonymous Chatterino users by typing that name.

It's declared here:

chatterino2/src/providers/twitch/TwitchCommon.hpp

Line 8 in e4af009

static const char *ANONYMOUS_USERNAME ATTR_UNUSED = "justinfan64537";

@fourtf fourtf added the bug Something isn't working as intended, or works in a confusing/unintuitive way for the user label Nov 4, 2020
@OlleSan
Copy link

OlleSan commented Nov 4, 2020

image

Solution for now.

@Y0dax
Copy link
Contributor

Y0dax commented Nov 9, 2020

Would it be possible to generate a random number postfix on app load rather than static 64537? At least that way users will be pseudo-unique

@pajlada
Copy link
Member

pajlada commented Nov 9, 2020

Would it be possible to generate a random number postfix on app load rather than static 64537? At least that way users will be pseudo-unique

There is an easier solution so we don't have to go this route

@fanway fanway mentioned this issue Nov 10, 2020
Closed
@pajlada pajlada mentioned this issue Jan 10, 2021
Merged
1 task
@Nerixyz Nerixyz mentioned this issue Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended, or works in a confusing/unintuitive way for the user
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix anonymous Twitch user ping Chatterino/chatterino2
4 participants
@pajlada @Y0dax @fourtf @OlleSan