Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Twitch v2 emote API for animated emote support #2863

Merged
merged 3 commits into from
Jun 4, 2021

Conversation

Bun
Copy link
Contributor

@Bun Bun commented Jun 4, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Using v2 paths is required for animated emotes, as can be seen in the following example.

Example of an animated emote:

https://static-cdn.jtvnw.net/emoticons/v1/303999817/3.0
https://static-cdn.jtvnw.net/emoticons/v2/303999817/default/dark/3.0
https://static-cdn.jtvnw.net/emoticons/v2/303999817/static/dark/3.0

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com>
Copy link
Collaborator

@zneix zneix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution 👍

@zneix zneix enabled auto-merge (squash) June 4, 2021 19:24
@zneix zneix merged commit 6611c24 into Chatterino:master Jun 4, 2021
@Bun Bun deleted the animated-emotes branch June 4, 2021 20:23
zneix added a commit to SevenTV/chatterino7 that referenced this pull request Jun 6, 2021
Now we're on commit 2f568b8; Changes from upstream we pulled:
 - Minor: Searching for users in the viewer list now searches anywhere in the user's name. (Chatterino#2861)
 - Minor: Now shows deletions of messages like timeouts (Chatterino#1155, Chatterino#2841)
 - Minor: Added a link to accounts page in settings to "You need to be logged in to send messages" message. (Chatterino#2862)
 - Minor: Switch to Twitch v2 emote API for animated emote support. (Chatterino#2863)
 - Bugfix: Fix reconnecting when IRC write connection is lost (Chatterino#1831, Chatterino#2356, Chatterino#2850)
 - Bugfix: Fixed bit emotes not loading in some rare cases. (Chatterino#2856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants