Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deletions show like timeouts/bans. #2841

Merged
merged 3 commits into from Jun 6, 2021

Conversation

Mm2PL
Copy link
Collaborator

@Mm2PL Mm2PL commented May 30, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Closes #1155.
Adds a notice for when a message gets deleted.

@Mm2PL
Copy link
Collaborator Author

Mm2PL commented May 30, 2021

lidl review request pajaDink

Mm2PL requested review from @zneix and @pajlada

@zneix zneix requested review from zneix and pajlada May 30, 2021 14:13
@pajlada
Copy link
Member

pajlada commented Jun 6, 2021

Behaviour in web chat:
image

Behaviour with this PR:
image

The extraneous space will be fixed, but other than that it looks good 👌

Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
@Mm2PL
Copy link
Collaborator Author

Mm2PL commented Jun 6, 2021

this Close #... is a mistake 4HEad

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pajlada pajlada merged commit f1e843a into Chatterino:master Jun 6, 2021
@pajlada pajlada deleted the feature/single_message_deletions branch June 6, 2021 15:51
zneix added a commit to SevenTV/chatterino7 that referenced this pull request Jun 6, 2021
Now we're on commit 2f568b8; Changes from upstream we pulled:
 - Minor: Searching for users in the viewer list now searches anywhere in the user's name. (Chatterino#2861)
 - Minor: Now shows deletions of messages like timeouts (Chatterino#1155, Chatterino#2841)
 - Minor: Added a link to accounts page in settings to "You need to be logged in to send messages" message. (Chatterino#2862)
 - Minor: Switch to Twitch v2 emote API for animated emote support. (Chatterino#2863)
 - Bugfix: Fix reconnecting when IRC write connection is lost (Chatterino#1831, Chatterino#2356, Chatterino#2850)
 - Bugfix: Fixed bit emotes not loading in some rare cases. (Chatterino#2856)
zneix added a commit to SevenTV/chatterino7 that referenced this pull request Jun 19, 2021
Now we're on commit d6b5921; Changes from upstream we pulled:

- Major: Added username autocompletion popup menu when typing usernames with an @ prefix. (Chatterino#1979, Chatterino#2866)
- Minor: The /live split now shows channels going offline. (Chatterino#2880)
- Minor: Now shows deletions of messages like timeouts (Chatterino#1155, Chatterino#2841, Chatterino#2867, Chatterino#2874)
- Bugfix: Moderation buttons now show the correct time unit when using units other than seconds. (Chatterino#1719, Chatterino#2864)
- Bugfix: Fixed bit and new subscriber emotes not (re)loading in some rare cases. (Chatterino#2856, Chatterino#2857)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleted messages wont show like timeout
3 participants