Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make single deletion messages for moderators obey the setting #3121

Conversation

Mm2PL
Copy link
Collaborator

@Mm2PL Mm2PL commented Aug 5, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Closes #3119

@Mm2PL Mm2PL requested review from fourtf and pajlada August 5, 2021 10:48
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works as intended 👍
image

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: ALazyMeme <jkeasley@icloud.com>
Copy link
Collaborator

@ALazyMeme ALazyMeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Felanbird
Copy link
Collaborator

As a note, this fix moves the total messages per deletion for mods from 2 to 1.

Setting on in current master
image

Setting on in this PR
image

@pajlada pajlada enabled auto-merge (squash) August 8, 2021 21:46
@pajlada pajlada merged commit b3bb7e2 into Chatterino:master Aug 8, 2021
@pajlada pajlada deleted the fix/make_deletion_messages_for_mods_obey_the_setting branch August 8, 2021 22:04
zneix added a commit to SevenTV/chatterino7 that referenced this pull request Aug 15, 2021
Now we're on commit 1d664f8; Changes from upstream we've pulled:

- Minor: Allow resub messages to show in `/mentions` tab (Chatterino#3148)
- Minor: Added a setting to hide similar messages by any user. (Chatterino#2716)
- Minor: Duplicate spaces now count towards the display message length. (Chatterino#3002)
- Minor: Commands are now backed up. (Chatterino#3168)
- Bugfix: Restored ability to send duplicate `/me` messages. (Chatterino#3166)
- Bugfix: Notifications for moderators about other moderators deleting messages can now be disabled. (Chatterino#3121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Show Deletions of Single Messages` not handling mod only versions of the messages.
4 participants